I was assigned to review Sonwright Gomex’s code. The code is well-organized and do not contain a lot of violations against the Java standard. It was commented well and was easy for me to follow along. I liked his strategy and he did a good job with the knights. All in all, this is a nicely written code and I had a good time reviewing it.
| File | Lines | Violation | Comments |
| MyRuler.java | 10,11,185,* | EJS-6 | Comment line has more than 100 characters |
| MyRuler.java | 12,17,25,* | ICS-SE-Java-6 | Comments hsould always end with a period |
| MyRuler.java | 16,17,18,* | ICS-SE-Eclipse-2 | Code should be indented 2 spaces instead of 4 |
| MyRuler.java | 16,172 | EJS-5 | The "else-if" should start on a new line |
| MyRuler.java | 193,201,210,* | EJS-76 | The "if" or "else" should always has curly braces |
No comments:
Post a Comment